docs: update permissions and provisioning #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Can you please also update the readme.md? Can you also please add an example for provisioning? That way we can close this issue #370 |
gwdawson
changed the title
|
In the readme can you please update this section as well? https://github.com/grafana/github-datasource?tab=readme-ov-file#access-token-permissions and also remove the first question from the faq? Thanks 🙏 |
|
@zoltanbedi as discussed in slack, i have removed all the duplicated documentation from the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when implementing the app token auth, i forgot to add the required permissions to the documentation. this pr lists all required permissions when using github app auth
this pr also updates the provisioning section of the docs to include app auth examples.
Before (permissions):
https://grafana.com/docs/plugins/grafana-github-datasource/latest/setup/token/#permissions
After (permissions):
Before (provisioning):
https://grafana.com/docs/plugins/grafana-github-datasource/latest/setup/provisioning/
After (provisioning):
Fixes #370