Add support for GitHub App authentication #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Left couple of comments. The only blocking issue is correctly handling queries when we don't have SelectedAuthType and default to personal-access-token. You could either solve it in func New(ctx context.Context, settings models.Settings) and default to createAccessTokenClient(ctx, settings). Or in func LoadSettings(settings backend.DataSourceInstanceSettings) where you would default to personal-access-token if no selectedAuthType is in settings.JSONData.
ivanahuckova
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability of authenticating with the github data source using GitHub Apps.