Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove query input in Vulnerabilities as not used and no API to support it #323

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

ivanahuckova
Copy link
Member

@ivanahuckova ivanahuckova commented Jun 18, 2024

While investigating #304 I noticed that:

  1. Query created in query field is not used in executed graphQL query to Github
  2. The vulnerabilityAlerts query that we are creating doesn't support query parameter (for example some apis support it - such as milestones or labels) https://docs.github.com/en/graphql/reference/objects. So even if we wanted to implement it, github would need to support it first. Also I have checked securityVulnerabilities query type, but it wasn't providing query param in any of these (also I am not sure if securityVulnerabilities and vulnerabilityAlerts are the same thing, but both don't have query so I didn't look further). And lastly I've checked serach, but it does not have vulnerabilities type.

I have checked github reqests/questions on community site and it seems that there is none related to adding query param. So it would be worth to probably start there, but I'll leave this for users requesting this feature to ask there.

So this PR removes query input and logic as it isn't used anywhere.

image image

Fixes #304

@ivanahuckova ivanahuckova requested a review from a team as a code owner June 18, 2024 15:00
@ivanahuckova ivanahuckova requested review from gabor, yesoreyeram and gwdawson and removed request for a team June 18, 2024 15:00
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanahuckova ivanahuckova reopened this Jun 19, 2024
@ivanahuckova ivanahuckova merged commit 8001ffe into main Jun 19, 2024
11 checks passed
@ivanahuckova ivanahuckova deleted the ivana/vulnerabilities-query branch June 19, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiVar not working in query type Pull Requests
2 participants