Fix: Remove query input in Vulnerabilities as not used and no API to support it #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #304 I noticed that:
vulnerabilityAlerts
query that we are creating doesn't supportquery
parameter (for example some apis support it - such asmilestones
orlabels
) https://docs.github.com/en/graphql/reference/objects. So even if we wanted to implement it, github would need to support it first. Also I have checkedsecurityVulnerabilities
query type, but it wasn't providingquery
param in any of these (also I am not sure ifsecurityVulnerabilities
andvulnerabilityAlerts
are the same thing, but both don't havequery
so I didn't look further). And lastly I've checkedserach
, but it does not have vulnerabilities type.I have checked github reqests/questions on community site and it seems that there is none related to adding
query
param. So it would be worth to probably start there, but I'll leave this for users requesting this feature to ask there.So this PR removes
query
input and logic as it isn't used anywhere.Fixes #304