Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

health check updates #288

Merged
merged 1 commit into from
Feb 7, 2024
Merged

health check updates #288

merged 1 commit into from
Feb 7, 2024

Conversation

yesoreyeram
Copy link
Contributor

  • currently health check retrieves list of all repos within grafana org. This requires lots of pagination and slow. Instead this PR filters the number of repos to github-datasource. with this no changes in existing behaviour but this will bit faster.
  • also when invalid/empty credentials entered, we currently show "health check failed". Instead this PR will show little more context. ( underlying library abstracts the error https://github.com/shurcooL/graphql/blob/ed46e5a4646634fc16cb07c3b8db389542cc8847/graphql.go#L79 . also we don't want to show this error message as retrieved for security reasons )

@yesoreyeram yesoreyeram requested a review from a team as a code owner February 7, 2024 13:33
@yesoreyeram yesoreyeram requested review from gabor, zoltanbedi and gwdawson and removed request for a team February 7, 2024 13:33
zoltanbedi
zoltanbedi approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@yesoreyeram yesoreyeram merged commit 4d98c54 into main Feb 7, 2024
3 checks passed
@yesoreyeram yesoreyeram deleted the healthcheck-changes branch February 7, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi zoltanbedi approved these changes

@gabor gabor Awaiting requested review from gabor gabor is a code owner automatically assigned from grafana/oss-big-tent

@gwdawson gwdawson Awaiting requested review from gwdawson gwdawson is a code owner automatically assigned from grafana/oss-big-tent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yesoreyeram @zoltanbedi