Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line filters: Allow backticks #992

Merged
merged 88 commits into from
Jan 10, 2025

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Jan 9, 2025

Allow backticks and any other char in line-filters.

This will use backticks by default, unless the line-filter contains a backtick, then it will wrap in double quotes and escape the content.

Related: grafana/grafana#98767

…sitive-localstorage' into gtk-grafana/issues/952/line-filter-ui-updates__regex-option
…sitive-localstorage' into gtk-grafana/issues/952/line-filter-ui-updates__regex-option
…2/line-filter-ui-updates__line-filter-var-v2
…2/line-filter-ui-updates__line-filter-var-v2
@gtk-grafana gtk-grafana mentioned this pull request Jan 9, 2025
1 task
@gtk-grafana

This comment was marked as outdated.

@gtk-grafana gtk-grafana changed the title Line filters: Validate backticks Line filters: Allow backticks Jan 9, 2025
@gtk-grafana gtk-grafana changed the base branch from gtk-grafana/issues/952/line-filter-ui-updates__line-filter-var-v2 to main January 9, 2025 20:37
@gtk-grafana gtk-grafana added this to the 1.0.6 milestone Jan 9, 2025
@gtk-grafana gtk-grafana self-assigned this Jan 9, 2025
@gtk-grafana gtk-grafana marked this pull request as ready for review January 9, 2025 20:45
@gtk-grafana gtk-grafana requested a review from a team as a code owner January 9, 2025 20:45
src/services/query.ts Show resolved Hide resolved
src/services/query.ts Outdated Show resolved Hide resolved
src/services/query.ts Outdated Show resolved Hide resolved
src/services/query.ts Outdated Show resolved Hide resolved
@gtk-grafana gtk-grafana added the enhancement New feature or request label Jan 10, 2025
Copy link
Contributor

@svennergr svennergr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtk-grafana gtk-grafana merged commit 032cbd9 into main Jan 10, 2025
4 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/issues/989/line-filters-validation branch January 10, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants