-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakdowns: Add share menu #983
Conversation
…1/share-menu
} | ||
}; | ||
|
||
export const copyStringToClipboard = (string: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use the existing function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh snap I never sent my comment:
copyText seems to require a button to append the textarea for fallback when clipboard.writeText isn't available, we should probably refactor copyText
to work like copyStringToClipboard
instead of the other way around.
Created #986 to track, I can clean this up in the morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. IIRC the other function has a backwards compatibility feature that makes it a bit more resilient.
Adds a share button similar to button in classic Explore:
Fixes: #771
Related: grafana/scenes#1022