feat(otelcol): allow event extraction from spans in spanlogs (grafana#2427) #2433
+149
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-hb
changed the title
steve-hb
force-pushed
the
spanlogs_event
branch
from
f550881 to
591b8e9
Compare
wildum
reviewed
Jan 17, 2025
| @@ -54,6 +54,8 @@ v1.6.0-rc.1 | |||
|
|
|||
| - Add a new `/-/healthy` endpoint which returns HTTP 500 if one or more components are unhealthy. (@ptodev) | |||
|
|
|||
| - Add `otelcol.connector.spanlogs` allowing to export span events as logs. (@steve-hb) | |||
There was a problem hiding this comment.
this entry is in the wrong place, it should be in the Main (unreleased) area
| | `span_attributes` | `list(string)` | Additional span attributes to log. | `[]` | no | | ||
| | `process_attributes` | `list(string)` | Additional process attributes to log. | `[]` | no | | ||
| | `event_attributes` | `list(string)` | Additional event attributes to log. | `[]` | no | | ||
| | `labels` | `list(string)` | A list of keys that will be logged as labels. | `[]` | no | | ||
|
|
||
| The values listed in `labels` should be the values of either span or process attributes. |
There was a problem hiding this comment.
there are a few areas like this one in this file that must be updated to include events attributes. If you could also update the example that would be awesome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #2427
Notes to the Reviewer
I'm not sure whether config converter update is needed here.
PR Checklist