Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the image version to work with the given example #2358

Merged

Conversation

adamab48
Copy link
Contributor

@adamab48 adamab48 commented Jan 9, 2025

PR Description

Updated the image version in the example given since it's old and does not work with the updated configuration

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

@adamab48 adamab48 requested a review from a team as a code owner January 9, 2025 12:24
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2025

CLA assistant check
All committers have signed the CLA.

@adamab48
Copy link
Contributor Author

adamab48 commented Jan 9, 2025

Fixes #2357

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release/v1.5 labels Jan 9, 2025
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@dehaansa dehaansa merged commit c22f0a1 into grafana:main Jan 9, 2025
17 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
mattdurham pushed a commit that referenced this pull request Jan 9, 2025
mattdurham added a commit that referenced this pull request Jan 14, 2025
* update changelog for rc (#2360)

* update changelog for rc

* update changelog for rc

* update changelog for rc (#2361)

* update version (#2362)

* update changelog for rc (#2360)

* update changelog for rc

* update changelog for rc

Signed-off-by: matt durham <[email protected]>

* fix conversion

* Fix changelog main (#2364)

* update version

* Fix changelog

* update the image version to work with the given example (#2358)

* docs: fixed kafka config example (#2359)

Example shows `loki.source.kafka "local"` pointing to `loki.relabel.kafka.receiver`. This leads to no new label being added. Correct example should have the kafka source pointing directly to `loki.write.local.receiver`

* feat(helm): add the ability to deploy extra manifest files (#2347)

* feat(helm): add the ability to deploy extra manifest files

* docs(helm): run helm-docs

* ci(helm): add tests

* Update wal queue tls (#2363)

* add tls to wal

* add alloy config

* update version

* Add support for TLS doc.

* Add changelog.

* fix import order

* add support and doc for round robin.

* fix conversion

* Update docs/sources/reference/components/prometheus/prometheus.write.queue.md

Co-authored-by: Clayton Cornell <[email protected]>

* Add test

* fix merge

* Update internal/component/prometheus/write/queue/types.go

Co-authored-by: William Dumont <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: William Dumont <[email protected]>

* #229 Add OpenTelemetry Collector Server Auth Extensions to Receivers (#2203)

* Work on adding auth so far

* Cleanup

* Made a ton of progress

* Fix test fails?

* Refactor

* Add auth blocks to implementing extensions

* Refactor to use feature flag

* Comments

* Cleanup

* Spacing

* Update docs

* Update CHANGELOG

* Last auth extension missing

* We also need grpc auth

* Fix opencensus docs

* Fix extra comment

* Update comment with findings

* Properly fix merge conflict

* Save file

* Spelling error

* That has been released now

* Add auth support to influxdb receiver

* Fix failing auth test/MAIL

* Comment cleanup

* MAIL for documentation

* docs MAIL

* MAIL

* Move from Auth to Authentication

* Update triton-go dependency to avoid embedded RSA key (#2380)

* Fix examples for filter and transform processors (#2379)

* fix examples filter and transform processors

* remove unecessary docs about escaping strings and backticks

* fix(loki.secretfilter): Fix partial masking for short secrets and support multiple allowlists per rule (#2320)

* Fix partial masking bug and support new allowlist format

* Add docs and changelog

* Update docs

* Add comments

* Add comments

* Minor docs update

* Add more tests

* Change criteria for partial redaction

* Changes to partial masking rules

* Fix comment location

* Clarify usage of secret types

* Clarify usage of secret types

* Update docs/sources/reference/components/loki/loki.secretfilter.md

Co-authored-by: Clayton Cornell <[email protected]>

* Suggestions

* Suggestions

---------

Co-authored-by: Clayton Cornell <[email protected]>

* Fix only run on fork guard (#2378)

* Fix only run on fork guard

The previous guard fails because `github.repository` resolves to the base repository on `pull_request` events.

* Fix syntax

* Fix relabel processed bug (#2394)

* Fix issue where alloy_prometheus_relabel_metrics_processed was not being incremented.

* Add unit tests

* Update WAL to version that supports v2. (#2397)

* Update WAL to version that supports v2.

* Update WAL to version that supports v2.

* Add samples check.

* Clean up Alloy component docs (#2387)

* First pass at cleanup, pretty tables, sort lists

* Sort content, add badge

* Fix link

* Set link URL correctly

* Still fxing link targets

* One more tidy pass

* database_observability: report health of component and collectors (#2392)

Report unhealthy in case of errors when starting up the collectors or
of any collector is stopped during operations.

* update for rc.1 (#2401)

* Update version.

* fix version

* fix version

---------

Signed-off-by: matt durham <[email protected]>
Co-authored-by: Adam ABICHOU <[email protected]>
Co-authored-by: Jay Clifford <[email protected]>
Co-authored-by: dbluxo <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: William Dumont <[email protected]>
Co-authored-by: Aidan Leuck <[email protected]>
Co-authored-by: Sam DeHaan <[email protected]>
Co-authored-by: Romain Gaillard <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Cristian Greco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.5 type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants