Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't start components until Run is called #2296

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Don't start components until Run is called #2296

merged 3 commits into from
Dec 18, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Dec 18, 2024

This is a patch to #2262 which prevents the OTel components from being started during New. It was discussed in this thread.

@ptodev ptodev requested a review from wildum December 18, 2024 07:54
wildum
wildum approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, you solved it in a way that's easily readable and is not ambiguous about race conditions. I'm happy to merge it in my PR and update my other PR: #2270

internal/component/otelcol/processor/processor.go Outdated Show resolved Hide resolved
internal/component/otelcol/internal/scheduler/scheduler.go Outdated Show resolved Hide resolved
internal/component/otelcol/internal/scheduler/scheduler.go Show resolved Hide resolved
@ptodev ptodev mentioned this pull request Dec 18, 2024
Open
@ptodev ptodev marked this pull request as ready for review December 18, 2024 13:42
@ptodev ptodev requested a review from a team as a code owner December 18, 2024 13:42
@ptodev
Copy link
Contributor Author

ptodev commented Dec 18, 2024

Hi @wildum, I polished the PR a bit. Please feel free to merge it in if you are still happy with it. I'll lift my "needs improvement" on #2262 and will let @thampiotr review it again. I'm a co-author now, so it doesn't feel right to approve it :)

@wildum wildum merged commit b133971 into fix-otel-scheduler Dec 18, 2024
15 checks passed
@wildum wildum deleted the ptodev/fix-otel-scheduler2 branch December 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildum wildum wildum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptodev @wildum