Skip to content

Commit

Permalink
Allow to override the cluster headless service port name for Istio su…
Browse files Browse the repository at this point in the history
…pport (#820)

This will be needed for an Istio mesh based installation due to this issue with headless services + Istio - https://istio.io/latest/docs/ops/common-problems/network-issues/#503-error-while-accessing-headless-services
  • Loading branch information
josh-thisisbud authored May 16, 2024
1 parent 4fb1df9 commit 1cdd942
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions operations/helm/charts/alloy/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ internal API changes are not present.
Unreleased
----------

### Bugfixes

- Fix clustering on instances running within Istio mesh by allowing to change the name of the clustering port

0.3.0 (2024-05-14)
------------------

Expand Down
1 change: 1 addition & 0 deletions operations/helm/charts/alloy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ useful if just using the default DaemonSet isn't sufficient.
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| alloy.clustering.enabled | bool | `false` | Deploy Alloy in a cluster to allow for load distribution. |
| alloy.clustering.portName | string | `"http"` | Name for the port used for clustering, useful if running inside an Istio Mesh |
| alloy.configMap.content | string | `""` | Content to assign to the new ConfigMap. This is passed into `tpl` allowing for templating from values. |
| alloy.configMap.create | bool | `true` | Create a new ConfigMap for the config file. |
| alloy.configMap.key | string | `nil` | Key in ConfigMap to get config from. |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
#
# This service should only be used for clustering, and not metric
# collection.
- name: http
- name: {{ $values.clustering.portName }}
port: {{ $values.listenPort }}
targetPort: {{ $values.listenPort }}
protocol: "TCP"
Expand Down
3 changes: 3 additions & 0 deletions operations/helm/charts/alloy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ alloy:
# -- Deploy Alloy in a cluster to allow for load distribution.
enabled: false

# -- Name for the port used for clustering, useful if running inside an Istio Mesh
portName: http

# -- Minimum stability level of components and behavior to enable. Must be
# one of "experimental", "public-preview", or "generally-available".
stabilityLevel: "generally-available"
Expand Down

0 comments on commit 1cdd942

Please sign in to comment.