-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prometheus/operator): accept relabel rules exported from prometheus.relabel
#6830
base: main
Are you sure you want to change the base?
feat(prometheus/operator): accept relabel rules exported from prometheus.relabel
#6830
Conversation
…heus.relabel` Signed-off-by: hainenber <[email protected]>
The `relabel_rules` argument can make use of the `rules` export value from a | ||
[prometheus.relabel][] component to apply one or more relabeling rules to metric data points | ||
before they're forwarded to the list of receivers in `forward_to`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `relabel_rules` argument can make use of the `rules` export value from a | |
[prometheus.relabel][] component to apply one or more relabeling rules to metric data points | |
before they're forwarded to the list of receivers in `forward_to`. | |
The `relabel_rules` argument uses the `rules` export value from a [prometheus.relabel][] component to apply one or more relabeling rules to your metric data points. The metric data points are relabeled and forwarded to the list of receivers in `forward_to`. |
A small rework to make the information active instead of passive. Is it still technically accurate with these changes?
If this is correct, this change shoudl be applied to teh other cases here in each of the following doc topics.
This PR has not had any activity in the past 30 days, so the |
Hey @hainenber, sorry for leaving you hanging for so long here 😞 Unfortunately I'm not sure about the proposed functionality in grafana/alloy#192, so I'm holding off on reviewing this from an implementation standpoint. We've recently introduced a new proposal review process that will help make it easier to understand when things still need discussion and when they're ready for work. I'm going to mark grafana/alloy#192 as a proposal so it can be discussed and we can reach consensus on whether this is something we want to do. |
No worries! It's always good having more opinions to a proposed addition. More code means more debts after all 🤤 |
Feel free to chime in for any proposal you think we should do, we want to welcome opinions from everyone and not just maintainers :) |
This PR has not had any activity in the past 30 days, so the |
PR Description
Which issue(s) this PR fixes
Closes grafana/alloy#192
Notes to the Reviewer
PR Checklist