Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add count connector #6575

Closed
wants to merge 1 commit into from
Closed

wip: add count connector #6575

wants to merge 1 commit into from

Conversation

rlankfo
Copy link
Member

@rlankfo rlankfo commented Feb 29, 2024

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@rlankfo rlankfo requested review from ptodev and jcreixell February 29, 2024 22:21
Signed-off-by: Robbie Lankford <[email protected]>
@rlankfo rlankfo requested a review from ptodev March 6, 2024 05:59

// SetToDefault implements river.Defaulter.
func (args *Arguments) SetToDefault() {
*args = DefaultArguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is more than one such connector in the config file, I wonder if there'd be a bug due to reusing the same DefaultArguments. E.g. if one connector overrides some defaults, but another one doesn't, then would the connector which only used defaults pick up the settings from the other one? I wonder if we should copy the slices with defaults every time we call SetToDefault

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can test this out. I noticed several other components following this pattern though, I'd assume they have the same issue if this is the case.

@tpaschalis
Copy link
Member

It's something for later on, when we're ready to merge, but let's make sure we also include a converter in the otelconvert package? We can help with that.

@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 12, 2024
@rlankfo rlankfo closed this Aug 1, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Sep 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. needs-attention An issue or PR has been sitting around and needs attention. variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants