Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix loki.source.heroku example #6396

Merged
merged 2 commits into from
Feb 20, 2024
Merged

docs: fix loki.source.heroku example #6396

merged 2 commits into from
Feb 20, 2024

Conversation

tpaschalis
Copy link
Member

I think the example for loki.source.heroku went stale after we started using a shared abstraction for the HTTP server. I've scanned the rest of the loki.source components and couldn't spot the same issue somewhere else.

Fixes #5295.

Signed-off-by: Paschalis Tsilias <[email protected]>
@clayton-cornell clayton-cornell enabled auto-merge (squash) February 20, 2024 18:32
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clayton-cornell clayton-cornell merged commit e621a01 into main Feb 20, 2024
10 checks passed
@clayton-cornell clayton-cornell deleted the fix-heroku-docs branch February 20, 2024 20:30
grafanabot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit e621a01)
grafanabot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit e621a01)
grafanabot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit e621a01)
clayton-cornell pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit e621a01)

Co-authored-by: Paschalis Tsilias <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit e621a01)

Co-authored-by: Paschalis Tsilias <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit e621a01)

Co-authored-by: Paschalis Tsilias <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.37 backport release-v0.38 backport release-v0.39 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs feedback: /docs/sources/flow/reference/components/loki.source.heroku.md
2 participants