Import - new modules #6350
Merged
Import - new modules #6350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An import source retrieves a module from a source. Add the ImportFile to retrieve a module from a file. Add the ImportString to retrieve a module from a string.
Add a new config node that retrieves a module via an import source. It will parse the module to collect declare and import blocks. For every imported import block it will create ImportConfigNode children. The children are evaluated and ran by the parent. By navigating through the import tree, it's possible to access all imported declares.
When an ImportConfigNode is evaluated, the custom component registry is updated. Custom components have edges to import node that they depend on. The componentNodeManager can search in the customComponentRegistry for imported declares. ImportConfigNodes are runnable nodes. They are ran by the controller. When a custom component is instantiated with an imported declare, it will have the customComponentRegistry associated with the scope of the import.
rfratto
reviewed
Feb 9, 2024
import.file should not have "isSecret" arg because the imported module is not exported. It should then not use the same args as local.file
wildum
force-pushed
the
import-new-modules-2
branch
from
11bb9fd to
77effec
Compare
rfratto
reviewed
Feb 16, 2024
rfratto
approved these changes
Feb 16, 2024
rfratto
approved these changes
Feb 20, 2024
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds the import functionality of the new modules with import.string and import.file.
The functionality is described in #5547
The change introduces a new type of node: ImportConfigNode.
It imports modules from an ImportSource to retrieve declare and import blocks.
For every import block, it creates an ImportConfigNode child. The child is evaluated and runs inside of its parent.
When the ImportSource retrieves new content, the ImportConfigNode updates its declares and import node children. Then it propagates an update to the root ImportConfigNode which will notify the controller that it has been updated.
The loader will then update the CustomComponentRegistry with new content and will trigger the dependants of the ImportConfigNode for reevaluation.
Notes to the Reviewer
The PR can be reviewed commit by commit.
PR Checklist