Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace relrefs with docrefs in Agent install and start topics #5572

Merged
merged 15 commits into from
Oct 24, 2023

Conversation

clayton-cornell
Copy link
Contributor

@clayton-cornell clayton-cornell commented Oct 23, 2023

PR Description

The relref shortcode is being deprecated in favour of the docs/reference shortcode. The new shortcode allows us to have more control over the references and links and makes sure that topics mounted into more than one project can have working links within that project.

This PR continues the process of migrating the Flow documentation to use the docs/reference shortcodes as preparation for mounting Flow topics into the Cloud docs

Which issue(s) this PR fixes

Notes to the Reviewer

I removed the Start Agent link from the Deploy Kubernetes topic - seemed to be redundant since the deployment doesn't need a start step (if I understand the K8s install correctly)

A couple of Notes were converted to block quote styled notes to allow doc/reference links within the Note. The doc/reference links do not work when embedded into other shortcodes. The linking works properly in a block quote and the published result is the same.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.37 labels Oct 23, 2023
@clayton-cornell clayton-cornell requested a review from a team October 23, 2023 17:53
@clayton-cornell clayton-cornell marked this pull request as ready for review October 23, 2023 18:03
@clayton-cornell clayton-cornell changed the title Replace relrefs with docrefs in Agent install and start topcis Replace relrefs with docrefs in Agent install and start topics Oct 23, 2023
Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 question to check out

@clayton-cornell clayton-cornell enabled auto-merge (squash) October 24, 2023 19:58
@clayton-cornell clayton-cornell merged commit 10cf125 into main Oct 24, 2023
7 checks passed
@clayton-cornell clayton-cornell deleted the docs/replace-relrefs-with-docrefs-second-patch branch October 24, 2023 20:02
grafanabot pushed a commit that referenced this pull request Oct 24, 2023
* Update links in macOS install topic

* Update links in binary install topic

* Update ref links on Windows and Kubernetes

* Remove start agent from Kubernetes install

* Update relrefs in Linux install topic

* Update relrefs in docker install topic

* Update relrefs in windoows config

* Update relrefs in configure linux topic

* Update relrefs in start and macos topics

* Fix typo in docker topic

* Remove extra blank line

* Remove redundant info

(cherry picked from commit 10cf125)
clayton-cornell added a commit that referenced this pull request Oct 24, 2023
#5592)

* Update links in macOS install topic

* Update links in binary install topic

* Update ref links on Windows and Kubernetes

* Remove start agent from Kubernetes install

* Update relrefs in Linux install topic

* Update relrefs in docker install topic

* Update relrefs in windoows config

* Update relrefs in configure linux topic

* Update relrefs in start and macos topics

* Fix typo in docker topic

* Remove extra blank line

* Remove redundant info

(cherry picked from commit 10cf125)

Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.37 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants