-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace relrefs with docrefs in Agent install and start topics #5572
Merged
clayton-cornell
merged 15 commits into
main
from
docs/replace-relrefs-with-docrefs-second-patch
Oct 24, 2023
Merged
Replace relrefs with docrefs in Agent install and start topics #5572
clayton-cornell
merged 15 commits into
main
from
docs/replace-relrefs-with-docrefs-second-patch
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
type/docs
Docs Squad label across all Grafana Labs repos
backport release-v0.37
labels
Oct 23, 2023
clayton-cornell
changed the title
Replace relrefs with docrefs in Agent install and start topcis
Replace relrefs with docrefs in Agent install and start topics
Oct 23, 2023
erikbaranowski
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 1 question to check out
clayton-cornell
deleted the
docs/replace-relrefs-with-docrefs-second-patch
branch
October 24, 2023 20:02
grafanabot
pushed a commit
that referenced
this pull request
Oct 24, 2023
* Update links in macOS install topic * Update links in binary install topic * Update ref links on Windows and Kubernetes * Remove start agent from Kubernetes install * Update relrefs in Linux install topic * Update relrefs in docker install topic * Update relrefs in windoows config * Update relrefs in configure linux topic * Update relrefs in start and macos topics * Fix typo in docker topic * Remove extra blank line * Remove redundant info (cherry picked from commit 10cf125)
clayton-cornell
added a commit
that referenced
this pull request
Oct 24, 2023
#5592) * Update links in macOS install topic * Update links in binary install topic * Update ref links on Windows and Kubernetes * Remove start agent from Kubernetes install * Update relrefs in Linux install topic * Update relrefs in docker install topic * Update relrefs in windoows config * Update relrefs in configure linux topic * Update relrefs in start and macos topics * Fix typo in docker topic * Remove extra blank line * Remove redundant info (cherry picked from commit 10cf125) Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
label
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport release-v0.37
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
type/docs
Docs Squad label across all Grafana Labs repos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The relref shortcode is being deprecated in favour of the docs/reference shortcode. The new shortcode allows us to have more control over the references and links and makes sure that topics mounted into more than one project can have working links within that project.
This PR continues the process of migrating the Flow documentation to use the docs/reference shortcodes as preparation for mounting Flow topics into the Cloud docs
Which issue(s) this PR fixes
Notes to the Reviewer
I removed the Start Agent link from the Deploy Kubernetes topic - seemed to be redundant since the deployment doesn't need a start step (if I understand the K8s install correctly)
A couple of Notes were converted to block quote styled notes to allow doc/reference links within the Note. The doc/reference links do not work when embedded into other shortcodes. The linking works properly in a block quote and the published result is the same.
PR Checklist