docs: Add label to prometheus.exporter.unix #5542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaschalis
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Thanks! This comes with the change that the component is no longer a singleton!
Could we also add a notice like the following, like we do for prometheus.scrape for example?
Multiple prometheus.exporter.unix components can be specified by giving them different labels.
jkroepke
commented
Oct 19, 2023
rfratto
added a commit
to rfratto/agent
that referenced
this pull request
Oct 19, 2023
PR grafana#5361 removed the concept of "singleton components" (components which must not have a user-specified label), and thus made prometheus.exporter.unix require a label. However, documentation referring to the old form of this component was not updated to include a label. Related to grafana#5542.
…x.md Co-authored-by: Jan-Otto Kröpke <[email protected]>
grafanabot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Co-authored-by: Jan-Otto Kröpke <[email protected]> (cherry picked from commit 1444962)
tpaschalis
pushed a commit
that referenced
this pull request
Oct 20, 2023
…el (#5543) PR #5361 removed the concept of "singleton components" (components which must not have a user-specified label), and thus made prometheus.exporter.unix require a label. However, documentation referring to the old form of this component was not updated to include a label. Related to #5542.
grafanabot
pushed a commit
that referenced
this pull request
Oct 20, 2023
…el (#5543) PR #5361 removed the concept of "singleton components" (components which must not have a user-specified label), and thus made prometheus.exporter.unix require a label. However, documentation referring to the old form of this component was not updated to include a label. Related to #5542. (cherry picked from commit 1ac8eac)
tpaschalis
pushed a commit
that referenced
this pull request
Oct 20, 2023
…el (#5543) (#5551) PR #5361 removed the concept of "singleton components" (components which must not have a user-specified label), and thus made prometheus.exporter.unix require a label. However, documentation referring to the old form of this component was not updated to include a label. Related to #5542. (cherry picked from commit 1ac8eac) Co-authored-by: Robert Fratto <[email protected]>
clayton-cornell
added a commit
that referenced
this pull request
Oct 20, 2023
Co-authored-by: Jan-Otto Kröpke <[email protected]> (cherry picked from commit 1444962) Co-authored-by: Jan-Otto Kröpke <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5361
PR Description
Missing label for prometheus.exporter.unix
See #5361
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist