Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for scheduled_task to Static documentation #5521

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

clayton-cornell
Copy link
Contributor

PR Description

This PR adds the missing documentation for scheduled_task to https://grafana.com/docs/agent/latest/static/configuration/integrations/windows-exporter-config/

Which issue(s) this PR fixes

Fixes #4341

Notes to the Reviewer

I made a guess at what was required based on the documentation for Flow and what I read in https://github.com/grafana/agent/blob/3d92001037b3a9915b1760a15683f3023a876b17/pkg/integrations/windows_exporter/config.go

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Contributor

@spartan0x117 spartan0x117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look at the code to verify, LGTM!

@clayton-cornell clayton-cornell merged commit f2b2456 into main Oct 18, 2023
11 checks passed
@clayton-cornell clayton-cornell deleted the docs/update-docs-scheduled_task branch October 18, 2023 00:14
grafanabot pushed a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit f2b2456)
grafanabot pushed a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit f2b2456)
grafanabot pushed a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit f2b2456)
clayton-cornell added a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit f2b2456)

Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell added a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit f2b2456)

Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell added a commit that referenced this pull request Oct 18, 2023
(cherry picked from commit f2b2456)

Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.35 backport release-v0.36 backport release-v0.37 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuring scheduled_task for windows_exporter
2 participants