Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a cross reference link in a note in the Agent root topic (v0.37) #5465

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

clayton-cornell
Copy link
Contributor

PR Description

This PR fixes a failing cross reference link from a note.

Restoring the original relref results in a broken link when this topic is mounted into the Grafana Cloud docs. Converting the link to a fully qualified link ensures the link will work in Agent docs and in Cloud docs. Refer to: https://grafana.com/docs/writers-toolkit/write/references/#choose-the-correct-link

Followup PR to #5464

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Oct 12, 2023
@clayton-cornell clayton-cornell requested a review from a team October 12, 2023 16:55
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third time's the charm?

@clayton-cornell
Copy link
Contributor Author

clayton-cornell commented Oct 12, 2023

Third time's the charm?

Try try again :-)

@clayton-cornell clayton-cornell enabled auto-merge (squash) October 12, 2023 16:58
@clayton-cornell clayton-cornell merged commit 557ebf1 into release-v0.37 Oct 12, 2023
@clayton-cornell clayton-cornell deleted the docs/fix_link_syntax branch October 12, 2023 16:59
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants