Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loki.process stage.sampling #5421

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

thampiotr
Copy link
Contributor

@thampiotr thampiotr commented Oct 10, 2023

PR Description

Part of #4836
This fell through the cracks for feature parity.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@thampiotr thampiotr force-pushed the thampiotr/loki-process-sampling-stage branch from 8aba7c9 to b99f129 Compare October 10, 2023 10:50
@thampiotr thampiotr marked this pull request as ready for review October 10, 2023 14:56
@thampiotr thampiotr requested review from a team and clayton-cornell as code owners October 10, 2023 14:56
@thampiotr thampiotr requested a review from tpaschalis October 10, 2023 14:57
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

util_log "github.com/grafana/loki/pkg/util/log"
)

var testSampingYaml = `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
var testSampingYaml = `
var testSampingRiver = `

@thampiotr thampiotr enabled auto-merge (squash) October 11, 2023 10:17
@thampiotr thampiotr merged commit 08dd42a into main Oct 11, 2023
7 checks passed
@thampiotr thampiotr deleted the thampiotr/loki-process-sampling-stage branch October 11, 2023 10:21
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants