Fix flaky test by increasing tolerance to process pauses #5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepalbi
approved these changes
Oct 6, 2023
thampiotr
force-pushed
the
thampiotr/fix-flaky-test-2
branch
from
bac7b9d to
e645772
Compare
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In CI, especially on slower machines or in presence of noisy neighbours, the execution of tests may be paused by GC or resource exhaustion for longer period of time, sometimes even multiple seconds. When our tests rely on some code executing within certain deadline, we can end up with flaky tests.
One way to fix it is to add more slack to the test, allowing it to pause for longer time. Another is to retry test on failure where it makes sense. In this PR I picked the first option as a simpler one that should increase the tolerance for pauses from 20ms to 200ms.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist