Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of otelcol.processor.discovery #5378

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Oct 5, 2023

PR Description

As #5306 shows, there has been some confusion regarding otelcol.processor.discovery, discovery components, and OpenTelemetry semantic conventions. I hope that this new addition to the docs will clear the confusion for future users.

Which issue(s) this PR fixes

Fixes #5306

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion for the docs input

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.36 backport release-v0.37 labels Oct 5, 2023
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are OK as-is

Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good to me and I always appreciate additional usage guidance 🚀

@ptodev ptodev merged commit 3627c89 into main Oct 11, 2023
6 checks passed
@ptodev ptodev deleted the 5306-otel-processor-discovery-component-clarify-use branch October 11, 2023 16:24
grafanabot pushed a commit that referenced this pull request Oct 11, 2023
* Clarify usage of otelcol.processor.discovery

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 3627c89)
grafanabot pushed a commit that referenced this pull request Oct 11, 2023
* Clarify usage of otelcol.processor.discovery

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 3627c89)
clayton-cornell pushed a commit that referenced this pull request Oct 12, 2023
* Clarify usage of otelcol.processor.discovery

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 3627c89)

Co-authored-by: Paulin Todev <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Oct 12, 2023
* Clarify usage of otelcol.processor.discovery

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 3627c89)

Co-authored-by: Paulin Todev <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.36 backport release-v0.37 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTEL processor discovery component enrichment issues
3 participants