Proposal: integration testing #5369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
reviewed
Oct 13, 2023
thampiotr
reviewed
Oct 13, 2023
thampiotr
reviewed
Oct 13, 2023
thampiotr
reviewed
Oct 13, 2023
| dir_name=$(basename "$test_dir") | ||
| agent_logfile="../../${tmp_dir}/${dir_name}_agent.log" | ||
| test_logfile="../../${tmp_dir}/${dir_name}_test.log" | ||
| "$AGENT_BINARY_PATH" run config.river > "$agent_logfile" 2>&1 & |
There was a problem hiding this comment.
Don't all the agents attempt to open on the same port 12345? How do you avoid this problem?
There was a problem hiding this comment.
I guess that the first one succeed and the other ones don't but that does not seem to create any problem. I will need to dig into that
thampiotr
reviewed
Oct 13, 2023
|
Draft Closed, PR opened here: #5475 |
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces integration testing to the agent for flow.
With a solid test coverage, the agent should be more stable and it should be easier to update code affecting several components without having to go through manual testing. This would be particularly valuable when updating important dependencies like OpenTelemetry or Prometheus. As a result, we might be able to accelerate the release process which is currently quite long.
Another benefit of these tests is to provide examples of pipelines to the users to help them understand how the components can interact together. With some luck, a user might be able to find a test with his exact use case and be able to just copy the config.river file.
PR Checklist