Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope.ebpf: add an demangling options #5351

Merged
merged 1 commit into from
Oct 3, 2023
Merged

pyroscope.ebpf: add an demangling options #5351

merged 1 commit into from
Oct 3, 2023

Conversation

korniltsev
Copy link
Contributor

@korniltsev korniltsev commented Oct 3, 2023

PR Description

Introduce an argument to configure c++ symbol demangling.
Available options are: none, simplified, templates, full. None is default.

Which issue(s) this PR fixes

grafana/pyroscope#2479
https://github.com/grafana/support-escalations/issues/7691

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@korniltsev korniltsev requested review from a team and clayton-cornell as code owners October 3, 2023 06:29
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit 190ab8f into main Oct 3, 2023
@korniltsev korniltsev deleted the ebpf-demangle branch October 3, 2023 09:20
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants