-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for updating Otel dependencies #4343
Conversation
edbbc2b
to
9ab8816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp; I don't personally have time to dive deep into this, but I don't want you to be blocked on getting docs merged. We can improve them over time.
@rfratto thank you, but based on your comment on another PR, I think the section on labeling the stability will have to be changed:
When someone updates the components, they need to know whether the stability label in the Agent docs is accurate. I'm not sure what is the best way to do this right now? E.g. some components which are beta in Collector might be stable in the Agent, etc. |
The stability level can always be increased but should never be decreased. We should be extra cautious when introducing new components. If we introduce it as stable, it's stable. |
3b1d7ee
to
c8680ce
Compare
@rfratto Thank you - I updated the instructions to say that stability lebels should never be decreased. Now they also say that if a stability in Otel has increased, the developer should check with the rest of the team on whether the Agent component's stability should also be increased. @wildum Would you mind reviewing the documentation please? I updated it just now to reflect some of the points we discussed on the PR. |
33002b7
to
313e6a3
Compare
313e6a3
to
2c7c31f
Compare
Putting in writing the lessons learned from #3858. Hopefully this helps us to do upgrades more often and with less effort.