Fix sometimes flaky test (#5391)

* Fix sometimes flaky test * Fix incorrect use of TestMain
grafana · Oct 6, 2023 · 671dd75 · 671dd75
1 parent 52ed27f
commit 671dd75
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/component/discovery/consulagent/promtail_consulagent_test.go b/component/discovery/consulagent/promtail_consulagent_test.go
@@ -367,14 +367,15 @@ func TestAllServices(t *testing.T) {
 
 	ctx, cancel := context.WithCancel(context.Background())
 	ch := make(chan []*targetgroup.Group)
+	done := make(chan struct{})
 	go func() {
 		d.Run(ctx, ch)
-		close(ch)
+		done <- struct{}{}
 	}()
 	checkOneTarget(t, <-ch)
 	checkOneTarget(t, <-ch)
 	cancel()
-	<-ch
+	<-done
 }
 
 // targetgroup with no targets is emitted if no services were discovered.