Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken syntax highlighting #200

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: broken syntax highlighting #200

merged 1 commit into from
Mar 6, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Mar 6, 2024 •
edited
Loading

Upgrading the deps seems to solve this problem:

  • @codemirror/lang-python to 6.1.4
  • @uiw/react-codemirror: 4.21.24

It seems that the problem come from codemirror and most particulary about python code…

image image

Trying to update the deps

After updating the deps, there is this error:

image

To solve this:

  1. remove all codemirror dependencies in packages.json (also in resolutions).
  2. run yarn command.
  3. clear yarn and npm cache:
yarn cache clean
npm cache clean --force
  1. clean vite cache npx vite —force.

This seems to also solve the highlight problem.

image

@ReidyT
feat(deps): update codemirror deps
1dba900 
- @codemirror/lang-python to 6.1.4
- @uiw/react-codemirror: 4.21.24
@ReidyT ReidyT self-assigned this Mar 6, 2024
@ReidyT ReidyT linked an issue Mar 6, 2024 that may be closed by this pull request
[bug] Syntax highlighting is broken ? #197
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ReidyT ReidyT changed the title feat(deps): update codemirror deps fix: solve broken syntax highlighting Mar 6, 2024
@ReidyT ReidyT changed the title fix: solve broken syntax highlighting fix: broken syntax highlighting Mar 6, 2024
@ReidyT ReidyT requested review from spaenleh and pyphilia March 6, 2024 11:00
pyphilia
pyphilia approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

spaenleh
spaenleh approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Let's see if it builds and deploys correctly 😄

@ReidyT ReidyT merged commit 8766c0a into main Mar 6, 2024
4 checks passed
@ReidyT ReidyT deleted the 197-syntax-highlighting-is-broken branch March 6, 2024 13:24
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@ReidyT ReidyT

Labels
v2.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Syntax highlighting is broken ?
3 participants
@ReidyT @pyphilia @spaenleh