Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows extended socket options #614

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Nov 10, 2023

Support for this got added to JDK 17.0.10+1 and, thus, the GraalVM code needs to account for this change. I don't have a Windows system at hand for this, so I'm relying ton GHA PR testing for this ;-)

Closes: #612

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 10, 2023
@jerboaa jerboaa requested a review from zakkak November 10, 2023 14:06
@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 10, 2023

Remaining CI issue is: quarkusio/quarkus#36975 (unrelated to this patch).

Support for this got added to JDK 17.0.10+1 and, thus,
the GraalVM code needs to account for this change.

Closes: oracle#612
@jerboaa jerboaa force-pushed the mandrel-22.3-windows-ext-net branch from 2f0a50d to 6433634 Compare November 10, 2023 16:49
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jerboaa !

@zakkak zakkak added this to the 22.3.5.0-Final milestone Nov 10, 2023
@zakkak zakkak added the release/noteworthy-feature A PR that is worth highlighting in the Changelog label Nov 10, 2023
@zakkak zakkak merged commit 2b6c34a into graalvm:mandrel/22.3 Nov 10, 2023
140 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. release/noteworthy-feature A PR that is worth highlighting in the Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[22.3] Windows build needs to account for new extended socket options in JDK 17.0.10
2 participants