Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.1] Backport: Updated JFR substitutions from [GR-54877] #763

Closed
1 of 2 tasks
roberttoyonaga opened this issue Jul 3, 2024 · 2 comments · Fixed by #764
Closed
1 of 2 tasks

[24.1] Backport: Updated JFR substitutions from [GR-54877] #763

roberttoyonaga opened this issue Jul 3, 2024 · 2 comments · Fixed by #764
Labels
affects/JDK23 Affects JDK 23 based Mandrel affects/24.1 Mandrel for JDK 23 backport
Milestone
24.1.0.0-Final

Comments

@roberttoyonaga
Copy link
Collaborator

roberttoyonaga commented Jul 3, 2024 •
edited
Loading

What would you like to backport?

Some JFR substitutions need to be updated. This labsjdk 24+3 updates patch fixes them in GraalVM oracle#9181

The whole patch should not be backported. Just the JFR parts (since the OpenJDK JFR patch was backported from 24 to 23).

Why?

Native image builds will fail if JFR is included. See: https://github.com/graalvm/mandrel/actions/runs/9762948079/job/26949412202?pr=762 and #762 (comment)

Are the changes being backported merged in upstream Graal?

  • Yes
  • No
@roberttoyonaga roberttoyonaga changed the title [24.1] Backport: [GR-54877] Update labsjdk to 24+3-jvmci-b01 [24.1] Backport: svm: adopt 'JDK-8304732' Jul 3, 2024
@roberttoyonaga roberttoyonaga changed the title [24.1] Backport: svm: adopt 'JDK-8304732' [24.1] Backport: Updated JFR substitutions from [GR-54877] Jul 3, 2024
@roberttoyonaga roberttoyonaga mentioned this issue Jul 3, 2024
Merged
@jerboaa jerboaa added this to the 24.1.0.0-Final milestone Jul 3, 2024
@jerboaa jerboaa linked a pull request Jul 3, 2024 that will close this issue
[24.1] Backport: Updated JFR substitutions from [GR-54877] #764
Merged
@jerboaa jerboaa added affects/JDK23 Affects JDK 23 based Mandrel affects/24.1 Mandrel for JDK 23 labels Jul 3, 2024
@zakkak
Copy link
Collaborator

zakkak commented Jul 4, 2024

@roberttoyonaga I think we can close this now that #764 is merged, right?

@jerboaa
Copy link
Collaborator

jerboaa commented Jul 4, 2024

I think so. Fixed with #764.

@jerboaa jerboaa closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/JDK23 Affects JDK 23 based Mandrel affects/24.1 Mandrel for JDK 23 backport
Projects
None yet
Milestone
24.1.0.0-Final
Development

Successfully merging a pull request may close this issue.

[24.1] Backport: Updated JFR substitutions from [GR-54877] robert-mandrel/mandrel
3 participants
@jerboaa @zakkak @roberttoyonaga