[24.1] Backport: Updated JFR substitutions from [GR-54877] #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p.java failed again with "Expected outer stream to have 3 events"' (cherry picked from commit fbc44e9)
oracle-contributor-agreement
bot
added
the
OCA Verified
2 tasks
|
Failing GHAs:
|
zakkak
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
LGTM other than the references to JDK 24 source code. @roberttoyonaga could you please adapt them accordingly? Thank you
...tevm/src/com.oracle.svm.core.posix/src/com/oracle/svm/core/posix/PosixPlatformTimeUtils.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/util/PlatformTimeUtils.java
Outdated
Show resolved
Hide resolved
zakkak
requested changes
Jul 3, 2024
There was a problem hiding this comment.
LGTM other than the references to JDK 24 source code. @roberttoyonaga could you please adapt them accordingly? Thank you
yes, thanks for spotting that. Done! |
jerboaa
referenced
this pull request
Jul 4, 2024
…p.java failed again with "Expected outer stream to have 3 events"'
jerboaa
approved these changes
Jul 4, 2024
zakkak
approved these changes
Jul 4, 2024
2 tasks
|
This backport was replaced by upstream oracle@27149a9, but we kept e308905 on top of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit fbc44e9)
Related issue: #763
A change to OpenJDK JFR was introduced in JDK 24 and later backported to JDK23+29. The Mandrel GHAs are using JDK23+29 so builds that include JFR will fail due to out of date substitutions.