Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: svm: adopt "JDK-8328366: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501" #6

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Backport: svm: adopt "JDK-8328366: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501" #6

merged 2 commits into from
Aug 22, 2024

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Aug 20, 2024

Hi,

Please review this backport of a fix from graal master needed by JDK-8328366 which got backported to JDK 21.0.5 (included in build 3 and better). It's the same as the upstream fix with the following modifications:

  • Use JDK21OrLater.class rather than JDK23OrLater.class
  • Fix up the import manually since the context around the added import changed.

Testing

I've run the quarkus integration test that failed before this backport and ran it again after it. Result is passed, issue is gone. See graalvm/mandrel#780 for details.

Thoughts?

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 20, 2024
@jerboaa jerboaa mentioned this pull request Aug 20, 2024
Closed
2 tasks
@zakkak zakkak linked an issue Aug 21, 2024 that may be closed by this pull request
[23.1] Backport: svm: adopt "JDK-8328366: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501" graalvm/mandrel#780
Closed
2 tasks
zapster and others added 2 commits August 22, 2024 15:51
@zapster @jerboaa
svm: adopt "JDK-8328366: Thread.setContextClassloader from thread in …
49dcd17 
…FJP commonPool task no longer works after JDK-8327501"

(cherry picked from commit 10bb0c6)
@zakkak @jerboaa
Fix style issues
dab7d02 
Style issues introduced by
graalvm#4
@jerboaa jerboaa force-pushed the JDK-8328366-fork-join-pool-backport branch from 2c74018 to dab7d02 Compare August 22, 2024 13:52
@jerboaa
Copy link
Contributor Author

jerboaa commented Aug 22, 2024

I've included the style fix from #7 on request from @zakkak.

zakkak
zakkak approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jerboaa.

I will merge once CI completes (Truffle failures are expected)

@zakkak
Copy link
Contributor

zakkak commented Aug 22, 2024

Truffle issues are known and unrelated, see #7 (comment)

@zakkak zakkak merged commit 7ff5518 into graalvm:master Aug 22, 2024
10 of 12 checks passed
@zakkak zakkak mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkak zakkak zakkak approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
3 participants
@jerboaa @zakkak @zapster