Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor rewording in graalpy-custom-venv-guide and graalpy-micronaut-guide #3

Merged
merged 1 commit into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graalpy/graalpy-custom-venv-guide/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

While GraalPy provides a [python-embedding](https://central.sonatype.com/artifact/org.graalvm.python/python-embedding) package and GraalPy [Maven plugin](https://www.graalvm.org/latest/reference-manual/python/Embedding-Build-Tools/) to simplify the required setup to ship Python packages
as Java resources or in separate folders, sometimes developers may want to install the Python packages manually
using the GraalPy standalone distribution and then use the manually installed packages in Java.
using the GraalPy standalone distribution, and then use these manually installed packages in Java.

This approach requires more effort, but may be useful in the following scenarios:

Expand Down
6 changes: 3 additions & 3 deletions graalpy/graalpy-micronaut-guide/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,8 @@ This will start the application on port 8080.

## 7. GraalVM Native Executable

*Note: Generating GraalVM native executable of Java applications that make use of Graal languages and virtual threads
at the same time is supported only on GraalVM JDK 23+. Notably, virtual threads support is unconditionally reachable
*Note: Generating GraalVM native executables of Java applications that make use of Graal languages and virtual threads
at the same time is supported only on GraalVM for JDK 23 and later. Notably, virtual threads support is unconditionally reachable
in Micronaut framework and therefore this applies also to our example.*

### 7.1. Native Executable metadata
Expand Down Expand Up @@ -492,4 +492,4 @@ to read on the Micronaut GraalPy plugin that can remove some of the boilerplate
- Learn more about GraalPy [Micronaut plugin](https://guides.micronaut.io/latest/micronaut-graalpy.html)
- Learn more about the GraalPy [Maven plugin](https://www.graalvm.org/latest/reference-manual/python/Embedding-Build-Tools/)
- Learn more about the Polyglot API for [embedding languages](https://www.graalvm.org/latest/reference-manual/embed-languages/)
- Explore in depth with GraalPy [reference manual](https://www.graalvm.org/latest/reference-manual/python/)
- Explore in depth with GraalPy [reference manual](https://www.graalvm.org/latest/reference-manual/python/)