Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support connection options value dictionary #15

Merged
merged 3 commits into from
Nov 18, 2024
Merged

fix: support connection options value dictionary #15

merged 3 commits into from
Nov 18, 2024

Conversation

luca-gr4vy
Copy link
Contributor

Description: After the changes here 7245b8f, integrations passing merchant_defined_data with a dictionary started having issues as Gr4vyConnectionOptionsValue doesn't support dictionaries. This adds support so integrators can pass it this way:

connectionOptions: [
    "cybersource-anti-fraud": [
        "merchant_defined_data": .dictionary(["1": "2"])
    ]
]

@luca-gr4vy luca-gr4vy merged commit 1e8fdab into main Nov 18, 2024
1 check passed
@luca-gr4vy luca-gr4vy deleted the fix/TA-9349-support-connection-options-value-dictionary branch November 18, 2024 14:56
JohnnyDevi pushed a commit to JohnnyDevi/gr4vy-ios that referenced this pull request Nov 18, 2024
Merge commit '1e8fdabe445c4c58ced5f12bd9f02c11242be803' into dev-jcj
758b047 
* commit '1e8fdabe445c4c58ced5f12bd9f02c11242be803':
  fix: support connection options value dictionary (gr4vy#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gryevns gryevns gryevns approved these changes

@AJ9 AJ9 Awaiting requested review from AJ9

@kim4tGr4vy kim4tGr4vy Awaiting requested review from kim4tGr4vy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luca-gr4vy @gryevns