chore: Upgrade rxdart #611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ferry-gql canceled.
|
|
Thanks! It seems that there are behavioral changes in rxdart which break some features of ferry related to paging + watching the cache. |
|
Given my current knowledge gap of the repo, I don't think I'll have the bandwidth to dive in and resolve this. I was hoping this would be a simple update. Will you be able to support this upgrade initiative? |
|
yes, you can try #612 The tests seems to work, but there is an additional run in the event loop required now due to the change in rxdart, which might affect widget tests (see the changed tests in the PR) |
|
Closing as #612 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.