refactor: Add const constructor to visitors

gql-dart · Oct 22, 2024 · 7851de0 · 7851de0
1 parent 12f047b
commit 7851de0
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 8 deletions.
diff --git a/docs/customization.md b/docs/customization.md
@@ -69,7 +69,7 @@ class AddTypenameTypedLink extends TypedLink {
           ..operation = Operation(
             document: transform(
               request.operation.document,
-              [AddTypenameVisitor()],
+              const [AddTypenameVisitor()],
             ),
             operationName: request.operation.operationName,
           ),

diff --git a/packages/ferry/lib/src/add_typename_typed_link.dart b/packages/ferry/lib/src/add_typename_typed_link.dart
@@ -22,7 +22,7 @@ class AddTypenameTypedLink extends TypedLink {
         (op) => Operation(
           document: transform(
             op.document,
-            [
+            const [
               AddTypenameVisitor(),
             ],
           ),

diff --git a/packages/ferry_generator/lib/src/utils/add_introspection.dart b/packages/ferry_generator/lib/src/utils/add_introspection.dart
@@ -14,6 +14,8 @@ const typenameField = FieldDefinitionNode(
 );
 
 class AddTypenameField extends TransformingVisitor {
+  const AddTypenameField();
+
   @override
   ObjectTypeDefinitionNode visitObjectTypeDefinitionNode(
     ObjectTypeDefinitionNode node,

diff --git a/packages/normalize/lib/src/denormalize_fragment.dart b/packages/normalize/lib/src/denormalize_fragment.dart
@@ -40,7 +40,7 @@ Map<String, dynamic>? denormalizeFragment({
   if (addTypename) {
     document = transform(
       document,
-      [AddTypenameVisitor()],
+      const [AddTypenameVisitor()],
     );
   }
   final fragmentMap = getFragmentMap(document);

diff --git a/packages/normalize/lib/src/denormalize_operation.dart b/packages/normalize/lib/src/denormalize_operation.dart
@@ -35,7 +35,7 @@ Map<String, dynamic>? denormalizeOperation({
   if (addTypename) {
     document = transform(
       document,
-      [AddTypenameVisitor()],
+      const [AddTypenameVisitor()],
     );
   }
 

diff --git a/packages/normalize/lib/src/normalize_fragment.dart b/packages/normalize/lib/src/normalize_fragment.dart
@@ -44,7 +44,7 @@ void normalizeFragment({
   // Always add typenames to ensure data is stored with typename
   document = transform(
     document,
-    [AddTypenameVisitor()],
+    const [AddTypenameVisitor()],
   );
 
   final fragmentMap = getFragmentMap(document);

diff --git a/packages/normalize/lib/src/normalize_operation.dart b/packages/normalize/lib/src/normalize_operation.dart
@@ -40,7 +40,7 @@ void normalizeOperation({
   if (addTypename) {
     document = transform(
       document,
-      [AddTypenameVisitor()],
+      const [AddTypenameVisitor()],
     );
   }
 

diff --git a/packages/normalize/lib/src/utils/add_typename_visitor.dart b/packages/normalize/lib/src/utils/add_typename_visitor.dart
@@ -1,6 +1,8 @@
 import 'package:gql/ast.dart';
 
 class AddTypenameVisitor extends TransformingVisitor {
+  const AddTypenameVisitor();
+
   @override
   FieldNode visitFieldNode(FieldNode node) {
     if (node.selectionSet == null) {

diff --git a/packages/normalize/lib/src/utils/validate_structure.dart b/packages/normalize/lib/src/utils/validate_structure.dart
@@ -97,7 +97,7 @@ bool _validateSelectionSet({
   if (addTypename) {
     document = transform(
       document,
-      [AddTypenameVisitor()],
+      const [AddTypenameVisitor()],
     );
   }
   final fragmentMap = getFragmentMap(document);

diff --git a/packages/normalize/lib/src/utils/well_known_directives.dart b/packages/normalize/lib/src/utils/well_known_directives.dart
@@ -41,7 +41,9 @@ bool isSkipped(SelectionNode node, Map<String, dynamic> variables) {
 
 class _SelectionNodeDirectiveVisitor
     extends SimpleVisitor<List<DirectiveNode>?> {
-  static final instance = _SelectionNodeDirectiveVisitor();
+  const _SelectionNodeDirectiveVisitor();
+
+  static const instance = _SelectionNodeDirectiveVisitor();
 
   @override
   List<DirectiveNode> visitFieldNode(FieldNode node) {