Ignore error when new column is added to DB schema (allow backward-compatible migrations) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
changed the title
VojtechVitek
commented
Jun 3, 2024
| @@ -2,6 +2,7 @@ CREATE TABLE accounts ( | |||
| id SERIAL PRIMARY KEY, | |||
| name VARCHAR(255), | |||
| disabled BOOLEAN, | |||
| new_column_not_in_code BOOLEAN, -- test for backward-compatible migrations, see https://github.com/goware/pgkit/issues/13 | |||
There was a problem hiding this comment.
This used to fail with
=== RUN TestSugarInsertAndSelectRows
pgkit_test.go:67:
Error Trace: /home/runner/work/pgkit/pgkit/tests/pgkit_test.go:67
Error: Received unexpected error:
pgkit: scanning: scanning: doing scan: scanFn: scany: column: 'new_column_not_in_code': no corresponding field found, or it's unexported in pgkit_test.Account
Test: TestSugarInsertAndSelectRows
pgkit_test.go:68:
Error Trace: /home/runner/work/pgkit/pgkit/tests/pgkit_test.go:68
Error: "[]" should have 1 item(s), but has 0
Test: TestSugarInsertAndSelectRows
Fixes this error: scany: column: 'new_field': no corresponding field found, or it's unexported in data.Collection
VojtechVitek
changed the title
VojtechVitek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13 -- Pgkit is not backward-compatible when a new column is added to a DB table schema