-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support release image on modern docker, upgrade guest distro to 22.04 #27
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR. The first commit looks good to me.
Regarding Ubuntu 22.04 |
So the issue with searching $PATH for docker-init is that modern installs put it at It's not clear to me what the downsides are of As for Ubuntu 22.04, there isn't a specific reason other than getting a newer kernel (I need some newer features). The s390x part of this project is irrelevant to me, but I understand the concern for maintaining support for it. Another option here (though maybe too-clever) would be to parameterize ARG UBUNTU_VERSION=20.04
FROM ubuntu:$UBUNTU_VERSION The we have the Makefile pass through an optional However, the downside, and where we'll introduce some more complexity is that we'll need some system for constructing Alternatively, we can add a Again, let me know what strategy you prefer, and I'd be happy to update the PR. |
I'm sorry for the confusing regarding the PATH. In all my systems the mount path is always |
If |
Regarding 22.04 I would prefer a second Dockerfile. If we integrate a second distro/version then we must always test and support it. The base kernel modules are copied into the initrd. Therefore we need the kernel.conf. I think we should make it possible to use 22.04+ but I don't want to switch now nor support two versions. There are other things waiting to be fixed, e.g. removing 'pkg/errors'. A 2nd. PR with a Dockerfile.2022 and maybe some instructions in the readme on how to use it is very welcome. |
Thanks @ConnorNelson |
The first commit fixes #24. It is not clear if #18 is still relevant, but it seems like passing
--init
is simpler to guarantee ourdocker-init
.The second commit brings the guest distro to ubuntu 22.04 (Linux 5.15.0-87-generic as of this PR).