Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for additional types #79

Merged
merged 15 commits into from
Aug 22, 2024
Merged

feat: support for additional types #79

merged 15 commits into from
Aug 22, 2024

Conversation

irainia
Copy link

@irainia irainia commented Aug 21, 2024

This PR is to support additional types, other than the built-in ones. The additional types are configurable, but should still follow certain requirements. Currently being set:

  • all lower case
  • combination of alphanumeric and underscore
  • with the length range [3-16]

@irainia irainia self-assigned this Aug 21, 2024
@irainia irainia requested a review from haveiss August 21, 2024 07:56
@coveralls
Copy link

coveralls commented Aug 21, 2024

Pull Request Test Coverage Report for Build 10500794425

Details

  • 27 of 27 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 85.175%

Totals Coverage Status
Change from base Build 10093937236: 0.04%
Covered Lines: 6366
Relevant Lines: 7474

💛 - Coveralls

core/asset/type.go Outdated Show resolved Hide resolved
@irainia irainia requested review from haveiss and batrov August 22, 2024 02:39
@haveiss haveiss merged commit c0bf977 into main Aug 22, 2024
3 checks passed
@haveiss haveiss deleted the feat-additional-types branch August 22, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants