Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Code Owners So Core Enablement can start reviewing the changes #2

Merged
merged 43 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
d9164dc
add codeowner for entire codebase to core-enablement
rkeur7 Oct 28, 2024
3d5f3bf
update makefile
rkeur7 Oct 28, 2024
ce10e11
initial patch for running tests in pipeline
rkeur7 Oct 28, 2024
07971f4
troubleshooting
rkeur7 Oct 28, 2024
a2950b0
more troubleshooting b/c local cannot replicate
rkeur7 Oct 28, 2024
daa5cd8
no null checks
rkeur7 Oct 28, 2024
938d5f9
revert test changes and update github workflow doc
rkeur7 Oct 28, 2024
5196627
revert changes for pipeline, missed env var earlier
rkeur7 Oct 28, 2024
0b08696
update generate workflow to pull apie key from secrets
rkeur7 Oct 29, 2024
f40f193
better naming convention :)
rkeur7 Oct 29, 2024
7db8e01
attempt pulling in shippo token from secrets
rkeur7 Oct 29, 2024
c0e80c6
next attempt
rkeur7 Oct 29, 2024
9cb7df6
try again
rkeur7 Oct 29, 2024
a233313
updates to correct yaml on generate and permissions on validate
rkeur7 Oct 29, 2024
bf5dc2f
clean up workflow docs, should extract duplicate effort eventually
rkeur7 Oct 29, 2024
534ef9e
spacing for readability
rkeur7 Oct 29, 2024
b2f69c9
piece apart workflow
rkeur7 Oct 29, 2024
a9c1ff2
encapsulate in steps
rkeur7 Oct 29, 2024
24a30d1
grrr
rkeur7 Oct 29, 2024
fc57467
this should be working
rkeur7 Oct 29, 2024
603de89
another attempt
rkeur7 Oct 29, 2024
e45c1e1
revert
rkeur7 Oct 29, 2024
2e89106
Update sdk_generation.yaml
rkeur7 Oct 29, 2024
0a8526e
Update sdk_generation.yaml
rkeur7 Oct 29, 2024
a8450b5
extract work to test
rkeur7 Oct 29, 2024
d084b12
attempt output but will remove b/c not safe
rkeur7 Oct 29, 2024
8d3c970
revert
rkeur7 Oct 29, 2024
30f1ca5
comment out speakeasy portion
rkeur7 Oct 30, 2024
d7aa73e
attempt speakeasy generate portion now
rkeur7 Oct 30, 2024
336a1d8
remove retrieve action and update generation
rkeur7 Oct 30, 2024
5bf61fb
restructure again
rkeur7 Oct 30, 2024
eb79111
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
068fb19
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
9dffaf5
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
bb7aa5f
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
a0dbf2c
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
5832195
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
9077f36
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
b7d4851
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
bd6c694
Update sdk_generation.yaml
rkeur7 Oct 30, 2024
ac4299e
update again
rkeur7 Oct 30, 2024
dd45c12
change to github_output
rkeur7 Oct 30, 2024
234cecf
reset generation workflow and update secret name from GH secrets
rkeur7 Oct 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @goshippo/core-enablement
30 changes: 22 additions & 8 deletions .github/workflows/sdk_generation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,25 @@ permissions:
- cron: 0 0 * * *
jobs:
generate:
uses: speakeasy-api/sdk-generation-action/.github/workflows/workflow-executor.yaml@v15
with:
force: ${{ github.event.inputs.force }}
mode: pr
speakeasy_version: latest
secrets:
github_access_token: ${{ secrets.GITHUB_TOKEN }}
speakeasy_api_key: ${{ secrets.SPEAKEASY_API_KEY }}
- name: "Authenticate with AWS"
uses: goshippo/shippo-action-workflows/.github/actions/[email protected]
with:
environment: dev-main
oidc-name: shippo-php-sdk-pipeline
login-to-ecr: false
- name: Get Speakeasy API Key
uses: aws-actions/aws-secretsmanager-get-secrets@v2
with:
secret-ids: |
dev-main-speakeasy-api-key
name-transformation: uppercase
parse-json-secrets: true
- name: "Speakeasy Generate"
uses: speakeasy-api/sdk-generation-action/.github/workflows/workflow-executor.yaml@v15
with:
force: ${{ github.event.inputs.force }}
mode: pr
speakeasy_version: latest
secrets:
github_access_token: ${{ secrets.GITHUB_TOKEN }}
speakeasy_api_key: ${{ env.DEV_MAIN_SPEAKEASY_API_KEY_PHP }}
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
LOCAL_SPEC_FILE=./build/public-api.yaml
BUILD_DIR=./build/
LOCAL_SPEC_FILE=${BUILD_DIR}public-api.yaml

check: test

Expand All @@ -13,7 +14,8 @@ speakeasy-install: # dev task, locally install the speakeasy CLI
speakeasy auth login

download-public-spec: # dev task, download the current public spec, in preparation for modifying and running speakeasy-generate
curl https://docs.goshippo.com/spec/shippoapi/public-api.yaml > $$LOCAL_SPEC_FILE
mkdir -p ${BUILD_DIR}
curl https://docs.goshippo.com/spec/shippoapi/public-api.yaml > ${LOCAL_SPEC_FILE}

speakeasy-generate: # dev task, run the generator on a local spec. useful for testing out changes to the spec or gen.yaml - but DO NOT commit the results of manual generation
if [ ! -f "${LOCAL_SPEC_FILE}" ]; then \
Expand Down
16 changes: 6 additions & 10 deletions phpunit.xml
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>

<phpunit bootstrap = "tests/bootstrap.php"
backupGlobals = "false"
backupStaticAttributes = "false"
colors = "true"
convertErrorsToExceptions = "true"
convertNoticesToExceptions = "true"
convertWarningsToExceptions = "true"
processIsolation = "false"
stopOnFailure = "false"
syntaxCheck = "false">
<phpunit bootstrap="tests/bootstrap.php"
backupGlobals="false"
colors="true"
processIsolation="false"
stopOnFailure="false">

<testsuites>
<testsuite name="Project Test Suite">
Expand All @@ -28,3 +23,4 @@
</php>

</phpunit>

Loading