Gorrion/task/szymon kedra #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sortCrewMembers inside of the mergeCrew function
…specific delay time to asynchronous function
…error when the passed page is non existant
…passed through props added
…onditions for isError isLoading and default where I pass the data
…nd wait function added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I successfully completed the assigned task, paying careful attention to all specified requirements. I've handled the data pagination (8 results per page) using React-Query, with next page prefetching when available. In terms of testing, I prioritized functionality assessments within both the endpoint and the 'lib' directory rather than concentrating on component testing. To enhance the user experience, I integrated a Loader featuring a spinner, and crafted an Error page complete with an icon.
Tools used: