-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use bun glob & update compressible extensions #67
base: master
Are you sure you want to change the base?
Conversation
added some more tiny changes :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but some minor issues
* @param {'gz' | 'br'} format | ||
*/ | ||
async function compress_file(file, format = "gz") { | ||
/*** @param {string} file* @param {'gz' | 'br'} format*/ async function compress_file( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there are some formatting issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there are some formatting issues
i ran bun format
before every commit
* @param {string} out | ||
*/ | ||
function patchServerWebsocketHandler(out) { | ||
/*** @param {string} out*/ function patchServerWebsocketHandler(out) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
* @param {import('.').CompressOptions} options | ||
*/ | ||
async function compress(directory, options) { | ||
/*** @param {string} directory* @param {import('.').CompressOptions} options*/ async function compress( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
const files = fileURLToPath(new URL("./files", import.meta.url).href); | ||
|
||
/** @type {import('.').default} */ | ||
export default function (opts = {}) { | ||
/** @type {import('.').default} */ export default function (opts = {}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
@@ -55,9 +55,6 @@ interface CompressOptions { | |||
*/ | |||
brotli?: boolean; | |||
|
|||
/** | |||
* @default html,js,json,css,svg,xml,wasm | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you removed this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you removed this comment?
because its way more than those anymore
this adds 2 changes: