Correct GOARCH docs #733
Merged
Correct GOARCH docs #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs had an extra `v` in the GOARCH+GOARM values for. Drop the `v` to match the actual translations: https://github.com/goreleaser/nfpm/blob/6c24137/apk/apk.go#L65-L66 https://github.com/goreleaser/nfpm/blob/6c24137/arch/arch.go#L46-L48 https://github.com/goreleaser/nfpm/blob/6c24137/deb/deb.go#L40-L42 https://github.com/goreleaser/nfpm/blob/6c24137/rpm/rpm.go#L63-L65
pull-request-size
bot
added
the
size/S
|
good catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs had an extra
vin the GOARCH+GOARM values.Drop the
vto match the actual translation tables:nfpm/apk/apk.go
Lines 65 to 66 in 6c24137
nfpm/arch/arch.go
Lines 46 to 48 in 6c24137
nfpm/deb/deb.go
Lines 40 to 42 in 6c24137
nfpm/rpm/rpm.go
Lines 63 to 65 in 6c24137