-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: enhance message encode #726
base: main
Are you sure you want to change the base?
Conversation
@magiconair Can you help review it? |
Is there a technical reason to not go all the way and replace the buffer allocations in all the write functions also?
could become
Just a thought. |
I think it's a good idea, I'll give it a try |
Signed-off-by: yuanliang <[email protected]>
Signed-off-by: yuanliang <[email protected]>
Signed-off-by: yuanliang <[email protected]>
commit 855932c benchstats results as follow:
|
Signed-off-by: yuanliang <[email protected]>
Signed-off-by: yuanliang <[email protected]>
Signed-off-by: yuanliang <[email protected]>
Signed-off-by: yuanliang <[email protected]>
Signed-off-by: yuanliang <[email protected]>
How does this relate to #729 and |
Using stream reduces memory allocation during message encoding and improves performance.
benchstat: