Prevent hanging on TCP connections that won't return [any/full] OPC UA data #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb0n
changed the title
magiconair
previously requested changes
Mar 22, 2023
This prevents io.ReadFull to hang.
magiconair
force-pushed
the
main
branch
2 times, most recently
from
8a74e38 to
beb72fb
Compare
|
I've rebased your changes onto @kung-foo it would be great if you could have a look at this as well. I've tagged this for v0.4 since this may have some wider implications. |
|
Hey thanks for the reply. I had a few things I was going to take out of
that CR, I'll do that as well as implement your suggestion.
…On Wed, Mar 22, 2023 at 6:53 AM Frank Schröder ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thank you. Can you just use a time.Duration and check if it is greater
than zero instead of using a pointer? Then I'll merge it.
—
Reply to this email directly, view it on GitHub
<#628 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALDTPYEHWZJ7FE6LKLTTWDW5L76NANCNFSM6AAAAAAT4DARHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great lib! I was using it to look at some interesting OPC UA servers I found on the internet (scanning for them truth be told) and ran into situations where io.ReadFull hangs forever. I made some changes and allowed the Dialer to have a read timeout it can pass to connections.