Skip to content

Commit

Permalink
subscription: do not fail Monitor() on bad node (#491)
Browse files Browse the repository at this point in the history
This patch restores the behavior of the Monitor() call to the v0.1
behavior of only returning an error if the Monitor call itself failed.

Fixes #491
  • Loading branch information
magiconair committed Nov 18, 2021
1 parent 3e18c6e commit e8a4934
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions subscription.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,6 @@ func (s *Subscription) Monitor(ts ua.TimestampsToReturn, items ...*ua.MonitoredI
return nil, err
}

for _, result := range res.Results {
if status := result.StatusCode; status != ua.StatusOK {
return nil, status
}
}

// store monitored items
// todo(fs): should we guard this with a lock?
for i, item := range items {
Expand Down

0 comments on commit e8a4934

Please sign in to comment.