CMake Cleanup #483
Open
CMake Cleanup #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. dashes almost never appear in variable names, and this tends to break syntax highlighters at least.
Would be better to use find_library et al, but they inexplicably failed.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most of the errors building with a newer toolchain, etc.
(I still have to
./gradlew sdk:assembleRelease extractNdkbefore trying to do anything with hellocardboard-android, but it does build and build nicely now.)Additionally, I added CMake options to control the optional parts of the Cardboard SDK. This is likely to be appreciated by downstream users who can reduce their diff against the official SDK by just configuring these variables, instead of editing the CMake file.