Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit supported react native version to <0.75.0 #332

Closed
wants to merge 4 commits into from

Conversation

jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Nov 7, 2024

The current version of this package does not support the latest React Native releases 0.75+. To prevent compatibility issues, this package should limit its peer dependency to versions below 0.75.0, providing users with an immediate indication of incompatibility.

Support for React Native 0.76+ is being tracked in a separate issue: #331

By limiting the peer dependency, users will see an informative error message if they attempt to use the package with an unsupported React Native version:

❯ npm i
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/react-native
npm error   react-native@"0.76.1" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react-native@">=0.74.1 <0.75.0" from @googlemaps/[email protected]
npm error node_modules/@googlemaps/react-native-navigation-sdk
...
  • Tests pass
  • Appropriate changes to documentation are included in the PR

@jokerttu jokerttu changed the title fix: limit supported react native version to <0.76.0 fix: limit supported react native version to <0.75.0 Nov 7, 2024
@jokerttu jokerttu force-pushed the fix/limit-supported-react-native-version branch from 9ddfa42 to f8df391 Compare November 7, 2024 11:56
Copy link
Contributor

@caio1985 caio1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu jokerttu closed this Nov 15, 2024
@jokerttu
Copy link
Contributor Author

Not relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants