feat: Add GMSMarker subclass allowance on cluster renderer #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
talipboke
force-pushed
the
talip/subclass-marker-renderer
branch
from
4ed59e8 to
0436e1e
Compare
Previously, when subclassing GMSMarker with a custom iconView, the iconView would not display on the map. This update enables custom iconViews to render correctly when using GMSMarker subclasses.
talipboke
force-pushed
the
talip/subclass-marker-renderer
branch
from
0436e1e to
00f7bdf
Compare
wangela
changed the title
wangela
changed the title
wangela
approved these changes
Nov 5, 2024
|
@iHackSubhodip As we have reviewed in your Swift translation branch, this change only applies to Objective-C and is not needed in the Swift version of the class. |
|
Thanks for review.I have closed the issue :) |
|
@wangela How does the merge process work? Do I need to do anything else? |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
If can not subclass GMSMarker with custom iconView can not see iconView on Map
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #505 🦕