Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markFeatureWriter: Support contextual anchors #869

Merged
merged 5 commits into from
Sep 19, 2024

Commits on Sep 4, 2024

  1. markFeatureWriter: Support contextual anchors

    This merges glyphsLib’s ContextualMarkFeatureWriter subclass back into
    MarkFeatureWriter. This is a mechanical merge with only the bare minimum
    changes to get things working. Some bug fixes and refactoring will
    happen in next commits.
    khaledhosny committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c5bbd06 View commit details
    Browse the repository at this point in the history
  2. markFeatureWriter: Fix test failures

    Check `key` is not empty before accessing first character.
    khaledhosny committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a6e57b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    38fb435 View commit details
    Browse the repository at this point in the history
  2. markFeatureWriter: Make contextual lookups only if mark feature is re…

    …quested
    
    We were trying to access non-existent features["mark"] when mark
    feature was disabled.
    khaledhosny committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fd0b5e3 View commit details
    Browse the repository at this point in the history
  3. markFeatureWriter: Ignore contextual anchors in non-contextual lookups

    Otherwise we end up with positioning statements that have duplicated
    mark classes like this:
    
    pos base a
       <anchor 200 200> mark @MC_top
       <anchor 100 200> mark @MC_top;
    
    (one is the regular anchor, and the other is the contextual one). Which
    makes no sense (feaLib shouldn’t probably allow the same mark class to
    be used multiple times in the same statement).
    khaledhosny committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e6ec270 View commit details
    Browse the repository at this point in the history