Add ability for RepoInfo to iter config files #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
iter-configs
branch
2 times, most recently
from
b4b08c5
to
7bf037b
Compare
rsheeter
reviewed
Oct 24, 2024
src/lib.rs
Outdated
| let rev = get_git_rev(&local_repo_dir).map_err(ConfigFetchIssue::GitFail)?; | ||
| Ok((configs, rev)) | ||
| if !skip_naive { | ||
| let naive = config_file_and_rev_from_remote_naive(repo_url).map(|(p, rev)| (vec![p], rev)); |
There was a problem hiding this comment.
nit: I don't find the naive naming informative, maybe we could be more descriptive? - for example, try_standard_config_location or some such
rsheeter
approved these changes
Oct 24, 2024
This will be necessary for building up a list of targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be necessary for building up a list of targets.