API tweaks from real use #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After trying to integrate this into the bulk builder, I've ran into a few little things I needed to change.
rsheeter
reviewed
Jun 28, 2024
| .expect("errored before now if url was malformed"), | ||
| .as_deref() | ||
| .and_then(repo_name_from_url) | ||
| .expect("already checked") |
There was a problem hiding this comment.
It's very annoying when these sort of checks hit and don't tell you anything about where the problem occurred. These days I'm fond of unwrap_or_else(|| panic!) so you can report context.
There was a problem hiding this comment.
I'm using expect here as basically an alternative to a comment; this be unreachable because in order to get here we already called this function once on this input and succeeded.
rsheeter
reviewed
Jun 28, 2024
| assert_eq!( | ||
| repo_name_from_url("https://github.com/hyper-type/Advent"), | ||
| Some("Advent"), | ||
| ); |
There was a problem hiding this comment.
I think this means we get a collision if font A has org1/a_name as repo and font B has org2/a_name. While perhaps unlikely I tend to think this would be a valid config.
There was a problem hiding this comment.
Agree this is possible, but unlikely. Opened #4 to track.
rsheeter
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to integrate this into the bulk builder, I've ran into a few little things I needed to change.